the-other-tim-brown commented on code in PR #14340:
URL: https://github.com/apache/hudi/pull/14340#discussion_r2585585941
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/RecordContext.java:
##########
@@ -244,6 +245,20 @@ public Comparable
convertOrderingValueToEngineType(Comparable value) {
public abstract GenericRecord convertToAvroRecord(T record, Schema schema);
+ /**
+ * Converts the engine-specific record to an Avro GenericRecord using
HoodieSchema.
+ * This method uses HoodieSchema for in-memory processing while maintaining
+ * compatibility with existing Avro-based serialization.
+ *
+ * @param record The engine-specific record.
+ * @param schema The HoodieSchema of the record.
+ * @return An Avro GenericRecord.
+ * @since 1.2.0
+ */
+ public GenericRecord convertToAvroRecord(T record, HoodieSchema schema) {
Review Comment:
Similarly here, let's just migrate the method to use HoodieSchema instead of
having two options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
