danny0405 commented on code in PR #13590:
URL: https://github.com/apache/hudi/pull/13590#discussion_r2591217728
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java:
##########
@@ -487,6 +487,14 @@ public Map<String, List<HoodieRecord>> getDataBuffer() {
* Write function to trigger the actual write action.
*/
protected interface WriteFunction extends Serializable {
- List<WriteStatus> write(Iterator<HoodieRecord> records, BucketInfo
bucketInfo, String instant);
+ List<WriteStatus> writeImpl(Iterator<HoodieRecord> records, BucketInfo
bucketInfo, String instant);
Review Comment:
writeImpl -> doWrite
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/factory/CollectSinkTableFactory.java:
##########
@@ -61,7 +61,7 @@ public class CollectSinkTableFactory implements
DynamicTableSinkFactory {
public static final String FACTORY_ID = "collect";
// global results to collect and query
- public static final Map<Integer, List<Row>> RESULT = new HashMap<>();
+ public static final Map<Integer, List<Row>> RESULT = new
ConcurrentHashMap<>();
Review Comment:
why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
