voonhous commented on code in PR #14340:
URL: https://github.com/apache/hudi/pull/14340#discussion_r2591612412
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestBufferedRecordMerger.java:
##########
@@ -800,54 +804,64 @@ private BufferedRecordMerger<InternalRow>
createPartialMerger(RecordMergeMode me
);
}
- private static Schema getSchema1() {
- Schema fullSchema = Schema.createRecord("TestRecord", null, null, false);
- List<Schema.Field> fields = Arrays.asList(
- new Schema.Field("id",
Schema.createUnion(Arrays.asList(Schema.create(Schema.Type.NULL),
Schema.create(Schema.Type.STRING))), null, Schema.NULL_VALUE),
- new Schema.Field("name",
Schema.createUnion(Arrays.asList(Schema.create(Schema.Type.NULL),
Schema.create(Schema.Type.STRING))), null, Schema.NULL_VALUE),
- new Schema.Field("age",
Schema.createUnion(Arrays.asList(Schema.create(Schema.Type.INT),
Schema.create(Schema.Type.NULL))), null, 0),
- new Schema.Field("city",
Schema.createUnion(Arrays.asList(Schema.create(Schema.Type.NULL),
Schema.create(Schema.Type.STRING))), null, Schema.NULL_VALUE),
- new Schema.Field("timestamp",
Schema.createUnion(Arrays.asList(Schema.create(Schema.Type.LONG),
Schema.create(Schema.Type.NULL))), null, 0L)
+ private static HoodieSchema getSchema1() {
+ HoodieSchema nullSchema = HoodieSchema.create(HoodieSchemaType.NULL);
+ HoodieSchema stringSchema = HoodieSchema.create(HoodieSchemaType.STRING);
+ HoodieSchema intSchema = HoodieSchema.create(HoodieSchemaType.INT);
+ HoodieSchema longSchema = HoodieSchema.create(HoodieSchemaType.LONG);
+
+ List<HoodieSchemaField> fields = Arrays.asList(
+ HoodieSchemaField.of("id", HoodieSchema.createUnion(nullSchema,
stringSchema), null, HoodieSchema.NULL_VALUE),
+ HoodieSchemaField.of("name", HoodieSchema.createUnion(nullSchema,
stringSchema), null, HoodieSchema.NULL_VALUE),
+ HoodieSchemaField.of("age", HoodieSchema.createUnion(intSchema,
nullSchema), null, 0),
+ HoodieSchemaField.of("city", HoodieSchema.createUnion(nullSchema,
stringSchema), null, HoodieSchema.NULL_VALUE),
+ HoodieSchemaField.of("timestamp", HoodieSchema.createUnion(longSchema,
nullSchema), null, 0L)
);
- fullSchema.setFields(fields);
- return fullSchema;
+ return HoodieSchema.createRecord("TestRecord", null, null, fields);
}
- private static Schema getSchema2() {
+ private static HoodieSchema getSchema2() {
// Create a partial schema with only some fields
- Schema partialSchema = Schema.createRecord("PartialRecord", null, null,
false);
- partialSchema.setFields(Arrays.asList(
- new Schema.Field("precombine",
Schema.createUnion(Arrays.asList(Schema.create(Schema.Type.LONG),
Schema.create(Schema.Type.NULL))), null, 0),
- new Schema.Field("id",
Schema.createUnion(Arrays.asList(Schema.create(Schema.Type.NULL),
Schema.create(Schema.Type.STRING))), null, Schema.NULL_VALUE),
- new Schema.Field("name",
Schema.createUnion(Arrays.asList(Schema.create(Schema.Type.NULL),
Schema.create(Schema.Type.STRING))), null, Schema.NULL_VALUE)
- ));
- return partialSchema;
+ HoodieSchema nullSchema = HoodieSchema.create(HoodieSchemaType.NULL);
+ HoodieSchema stringSchema = HoodieSchema.create(HoodieSchemaType.STRING);
+ HoodieSchema longSchema = HoodieSchema.create(HoodieSchemaType.LONG);
+
+ List<HoodieSchemaField> fields = Arrays.asList(
+ HoodieSchemaField.of("precombine",
HoodieSchema.createUnion(longSchema, nullSchema), null, 0),
Review Comment:
Swapped them out, will search for other references that i modified too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
