vamsikarnika commented on code in PR #17460:
URL: https://github.com/apache/hudi/pull/17460#discussion_r2592579497
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/ShowArchivedCommitsProcedure.scala:
##########
@@ -31,12 +31,17 @@ import java.util.function.Supplier
import scala.collection.JavaConverters._
+/**
+ * @deprecated Use [[ShowCommitsProcedure]] with showArchived=true instead
which provides a comprehensive view of commit operations
+ */
+@Deprecated
class ShowArchivedCommitsProcedure(includeExtraMetadata: Boolean) extends
BaseProcedure with ProcedureBuilder {
private val PARAMETERS = Array[ProcedureParameter](
ProcedureParameter.required(0, "table", DataTypes.StringType),
ProcedureParameter.optional(1, "limit", DataTypes.IntegerType, 10),
- ProcedureParameter.optional(2, "start_ts", DataTypes.StringType, ""),
- ProcedureParameter.optional(3, "end_ts", DataTypes.StringType, "")
+ ProcedureParameter.optional(2, "startTime", DataTypes.StringType, ""),
+ ProcedureParameter.optional(3, "endTime", DataTypes.StringType, ""),
+ ProcedureParameter.optional(4, "filter", DataTypes.StringType, "")
Review Comment:
I see that we're following snake case in other procedures? we should do the
same here to maintain consistency
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/ShowArchivedCommitsProcedure.scala:
##########
@@ -31,12 +31,17 @@ import java.util.function.Supplier
import scala.collection.JavaConverters._
+/**
+ * @deprecated Use [[ShowCommitsProcedure]] with showArchived=true instead
which provides a comprehensive view of commit operations
+ */
+@Deprecated
class ShowArchivedCommitsProcedure(includeExtraMetadata: Boolean) extends
BaseProcedure with ProcedureBuilder {
private val PARAMETERS = Array[ProcedureParameter](
ProcedureParameter.required(0, "table", DataTypes.StringType),
ProcedureParameter.optional(1, "limit", DataTypes.IntegerType, 10),
- ProcedureParameter.optional(2, "start_ts", DataTypes.StringType, ""),
- ProcedureParameter.optional(3, "end_ts", DataTypes.StringType, "")
+ ProcedureParameter.optional(2, "startTime", DataTypes.StringType, ""),
+ ProcedureParameter.optional(3, "endTime", DataTypes.StringType, ""),
Review Comment:
I see that we're following snake case in other procedures? we should do the
same here to maintain consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
