the-other-tim-brown commented on code in PR #14382:
URL: https://github.com/apache/hudi/pull/14382#discussion_r2593380043
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/schema/FilebasedSchemaProvider.java:
##########
@@ -92,11 +93,25 @@ public FilebasedSchemaProvider(Configuration conf) {
}
@Override
+ public HoodieSchema getSourceHoodieSchema() {
Review Comment:
let's just let this use the implementation in the abstract class
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/schema/SchemaRegistryProvider.java:
##########
@@ -115,6 +116,14 @@ private Schema getSchema(String registryUrl) throws
IOException {
}
@Override
+ public HoodieSchema getSourceHoodieSchema() {
Review Comment:
Similarly here, just leave the implementation as it is in master by allowing
the parent class handle this fallback
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/schema/FilebasedSchemaProvider.java:
##########
@@ -92,11 +93,25 @@ public FilebasedSchemaProvider(Configuration conf) {
}
@Override
+ public HoodieSchema getSourceHoodieSchema() {
+ Schema schema = getSourceSchema();
+ return schema == null ? null : HoodieSchema.fromAvroSchema(schema);
+ }
+
+ @Override
+ @Deprecated
public Schema getSourceSchema() {
return sourceSchema;
}
@Override
+ public HoodieSchema getTargetHoodieSchema() {
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
