danny0405 commented on code in PR #17517:
URL: https://github.com/apache/hudi/pull/17517#discussion_r2597010833
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##########
@@ -245,6 +246,10 @@ public void close() throws IOException {
private void closeStream() throws IOException {
if (output != null) {
flush();
+ // Before closing the stream, call `FSDataOutputStream#hsync` to
manually request DataNodes to perform data flushing to enhance the data
persistence capability
+ // NOTE : the following API call makes sure that the data is flushed to
disk on DataNodes (akin to POSIX fsync())
+ // See more details here : https://issues.apache.org/jira/browse/HDFS-744
+ output.hsync();
Review Comment:
it looks like the hsync is changed to be invoked per-file instead of
per-datablock, @balaji-varadarajan-ai can you help to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
