yanghua commented on a change in pull request #2281:
URL: https://github.com/apache/hudi/pull/2281#discussion_r550216289
##########
File path:
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/testutils/HoodieWriteableTestTable.java
##########
@@ -104,29 +80,7 @@ public HoodieWriteableTestTable forCommit(String
instantTime) {
return (HoodieWriteableTestTable) super.forCommit(instantTime);
}
- public String getFileIdWithInserts(String partition) throws Exception {
- return getFileIdWithInserts(partition, new HoodieRecord[0]);
- }
-
- public String getFileIdWithInserts(String partition, HoodieRecord...
records) throws Exception {
- return getFileIdWithInserts(partition, Arrays.asList(records));
- }
-
- public String getFileIdWithInserts(String partition, List<HoodieRecord>
records) throws Exception {
- String fileId = UUID.randomUUID().toString();
- withInserts(partition, fileId, records);
- return fileId;
- }
-
- public HoodieWriteableTestTable withInserts(String partition, String fileId)
throws Exception {
- return withInserts(partition, fileId, new HoodieRecord[0]);
- }
-
- public HoodieWriteableTestTable withInserts(String partition, String fileId,
HoodieRecord... records) throws Exception {
- return withInserts(partition, fileId, Arrays.asList(records));
- }
-
- public HoodieWriteableTestTable withInserts(String partition, String fileId,
List<HoodieRecord> records) throws Exception {
+ public HoodieWriteableTestTable withInserts(String partition, String fileId,
List<HoodieRecord> records, TaskContextSupplier contextSupplier) throws
Exception {
Review comment:
This line is too long, it would be better if we could break it. But it
does not matter, let's refactor it next time.
##########
File path:
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/testutils/HoodieWriteableTestTable.java
##########
@@ -104,29 +80,7 @@ public HoodieWriteableTestTable forCommit(String
instantTime) {
return (HoodieWriteableTestTable) super.forCommit(instantTime);
}
- public String getFileIdWithInserts(String partition) throws Exception {
- return getFileIdWithInserts(partition, new HoodieRecord[0]);
- }
-
- public String getFileIdWithInserts(String partition, HoodieRecord...
records) throws Exception {
- return getFileIdWithInserts(partition, Arrays.asList(records));
- }
-
- public String getFileIdWithInserts(String partition, List<HoodieRecord>
records) throws Exception {
- String fileId = UUID.randomUUID().toString();
- withInserts(partition, fileId, records);
- return fileId;
- }
-
- public HoodieWriteableTestTable withInserts(String partition, String fileId)
throws Exception {
- return withInserts(partition, fileId, new HoodieRecord[0]);
- }
-
- public HoodieWriteableTestTable withInserts(String partition, String fileId,
HoodieRecord... records) throws Exception {
- return withInserts(partition, fileId, Arrays.asList(records));
- }
-
- public HoodieWriteableTestTable withInserts(String partition, String fileId,
List<HoodieRecord> records) throws Exception {
+ public HoodieWriteableTestTable withInserts(String partition, String fileId,
List<HoodieRecord> records, TaskContextSupplier contextSupplier) throws
Exception {
Review comment:
This line is too long, it would be better if we could break it. But it
does not matter, let's refactor it next time.
##########
File path:
hudi-client/hudi-flink-client/src/test/java/org/apache/hudi/testutils/HoodieFlinkClientTestHarness.java
##########
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.testutils;
+
+import org.apache.hudi.common.fs.FSUtils;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.model.HoodieTableType;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.testutils.HoodieCommonTestHarness;
+import org.apache.hudi.common.testutils.HoodieTestUtils;
+
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
+import org.apache.flink.streaming.api.functions.sink.SinkFunction;
+import org.apache.flink.test.util.MiniClusterWithClientResource;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocalFileSystem;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.TestInfo;
+
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.List;
+
+public class HoodieFlinkClientTestHarness extends HoodieCommonTestHarness
implements Serializable {
+
+ protected static final Logger LOG =
LogManager.getLogger(HoodieFlinkClientTestHarness.class);
Review comment:
It would be better to split the non-static and static fields, moreover,
it is a logger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
