yihua commented on code in PR #17520:
URL: https://github.com/apache/hudi/pull/17520#discussion_r2600499683
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieReaderConfig.java:
##########
@@ -45,14 +45,6 @@ public class HoodieReaderConfig extends HoodieConfig {
.withDocumentation("HoodieLogFormatReader reads a logfile in the forward
direction starting from pos=0 to pos=file_length. "
+ "If this config is set to true, the reader reads the logfile in
reverse direction, from pos=file_length to pos=0");
- public static final ConfigProperty<String> ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN
= ConfigProperty
- .key("hoodie" + HoodieMetadataConfig.OPTIMIZED_LOG_BLOCKS_SCAN)
- .defaultValue("false")
Review Comment:
This changes the behavior by using the optimized log block scan by default.
I remember that the optimized log block scan has two passes which increase the
number of FS calls, which can be noticeable on cloud storage. Is the overhead
measured and negligible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
