n3nash commented on a change in pull request #2188:
URL: https://github.com/apache/hudi/pull/2188#discussion_r550341786
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/hbase/SparkHoodieHBaseIndex.java
##########
@@ -480,6 +486,68 @@ private Integer getNumRegionServersAliveForTable() {
@Override
public boolean rollbackCommit(String instantTime) {
// Rollback in HbaseIndex is managed via method {@link
#checkIfValidCommit()}
+ synchronized (SparkHoodieHBaseIndex.class) {
Review comment:
@hj2016 Can you please make the following changes :
`public boolean rollbackCommit(String instantTime) {
if (config.getHBaseIndexRollbackSync()) {
// <move all your new code here>
}
return true;
`
This keeps old behavior unchanged and safe and allows you to control deletes
via the config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
