vinothchandar commented on a change in pull request #2398:
URL: https://github.com/apache/hudi/pull/2398#discussion_r550722462



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
##########
@@ -240,12 +252,14 @@ public static void processFiles(FileSystem fs, String 
basePathStr, Function<File
     }
   }
 
-  public static List<String> getAllPartitionPaths(FileSystem fs, String 
basePathStr, boolean assumeDatePartitioning)
-      throws IOException {
+  public static List<String> getAllPartitionPaths(FileSystem fs, String 
basePathStr, boolean useFileListingFromMetadata, boolean verifyListings,
+                                                  boolean 
assumeDatePartitioning) throws IOException {
     if (assumeDatePartitioning) {

Review comment:
       I think there is a fallback code inside `HoodieBackedTableMetadata`. but 
yeah I ll add one to `HoodieTableMetadata#create()` to return a different impl 
when `useFileListingFromMetadata=false` 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to