n3nash commented on a change in pull request #2374: URL: https://github.com/apache/hudi/pull/2374#discussion_r550972144
########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/lock/FileSystemBasedLockProvider.java ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.client.lock; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.common.config.LockConfiguration; +import org.apache.hudi.common.lock.LockProvider; +import org.apache.hudi.exception.HoodieIOException; +import org.apache.hudi.exception.HoodieLockException; + +import java.io.IOException; + +import static org.apache.hudi.common.config.LockConfiguration.FILESYSTEM_LOCK_PATH_PROP; +import static org.apache.hudi.common.config.LockConfiguration.HOODIE_LOCK_ACQUIRE_NUM_RETRIES_PROP; +import static org.apache.hudi.common.config.LockConfiguration.HOODIE_LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS_PROP; + +/** + * This lock provider is used to testing purposes only. It provides a simple file system based lock using HDFS atomic + * create operation. This lock does not support cleaning/expiring the lock after a failed write hence cannot be used + * in production environments. + */ +public class FileSystemBasedLockProvider extends LockProvider { + + private static final String LOCK_NAME = "acquired"; + + private String lockPath; + private FileSystem fs; + + public FileSystemBasedLockProvider(LockConfiguration lockConfiguration, final Configuration configuration) { + try { + this.lockConfiguration = lockConfiguration; + this.lockPath = lockConfiguration.getConfig().getString(FILESYSTEM_LOCK_PATH_PROP); + this.fs = FileSystem.get(configuration); Review comment: Moved this to test scope ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
