rahil-c commented on code in PR #17475:
URL: https://github.com/apache/hudi/pull/17475#discussion_r2606887557
##########
hudi-spark-datasource/hudi-spark4-common/src/main/scala/org/apache/spark/sql/adapter/BaseSpark4Adapter.scala:
##########
@@ -73,6 +73,8 @@ abstract class BaseSpark4Adapter extends SparkAdapter with
Logging {
override def getAvroSchemaConverters: HoodieAvroSchemaConverters =
HoodieSparkAvroSchemaConverters
+ override def getHoodieSchemaConverters: HoodieSchemaConverters =
HoodieSparkSchemaConverters
Review Comment:
I think we can try to use directly `HoodieSparkSchemaConverters` and see
what occurs since you are right that now all spark versions seem to be using
same convetrer and see if we can reduce code. If i run into issues though will
opt to keep existing pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
