rahil-c commented on code in PR #17475:
URL: https://github.com/apache/hudi/pull/17475#discussion_r2608138671
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala:
##########
@@ -35,19 +34,19 @@ import scala.collection.JavaConverters._
*/
@DeveloperApi
-private[sql] object HoodieSchemaInternalConverters extends
HoodieSchemaConverters {
+object HoodieSparkSchemaConverters {
/**
* Internal wrapper for SQL data type and nullability.
*/
case class SchemaType(dataType: DataType, nullable: Boolean)
- override def toSqlType(hoodieSchema: HoodieSchema): (DataType, Boolean) = {
+ def toSqlType(hoodieSchema: HoodieSchema): (DataType, Boolean) = {
val result = toSqlTypeHelper(hoodieSchema, Set.empty)
(result.dataType, result.nullable)
}
- override def toHoodieType(catalystType: DataType, nullable: Boolean,
recordName: String, nameSpace: String): HoodieSchema = {
+ def toHoodieType(catalystType: DataType, nullable: Boolean, recordName:
String, nameSpace: String = ""): HoodieSchema = {
Review Comment:
remove this extra change not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
