voonhous commented on code in PR #17535:
URL: https://github.com/apache/hudi/pull/17535#discussion_r2608913770
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -1015,11 +1016,13 @@ static void validateSecondaryIndexSchemaEvolution(
}
// Use AvroSchemaCompatibility's field lookup logic to handle aliases
- Schema.Field writerField =
AvroSchemaCompatibility.lookupWriterField(writerSchema, tableField);
+ HoodieSchemaField writerField =
HoodieSchemaCompatibility.lookupWriterField(writerSchema, tableField);
if (writerField != null &&
!tableField.schema().equals(writerField.schema())) {
// Check if this is just making the field nullable/non-nullable, which
is safe from SI perspective
- if
(getNonNullTypeFromUnion(tableField.schema()).equals(getNonNullTypeFromUnion(writerField.schema())))
{
+ HoodieSchema nonNullTableField =
HoodieSchemaUtils.getNonNullTypeFromUnion(tableField.schema());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
