yihua commented on code in PR #14357:
URL: https://github.com/apache/hudi/pull/14357#discussion_r2609405952
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java:
##########
@@ -348,8 +349,21 @@ private void scanInternalV1(Option<KeySpec> keySpecOpt) {
// Eat exception as we do not want to mask the original exception that
can happen
LOG.error("Unable to close log format reader", ioe);
}
- LOG.info("Finished scanning log files. Total log files: {}, Total log
blocks: {}, Total rollbacks: {}, Total corrupt blocks: {}",
- totalLogFiles.get(), totalLogBlocks.get(), totalRollbacks.get(),
totalCorruptBlocks.get());
+ if (!logFiles.isEmpty()) {
+ try {
+ String fileId =
FSUtils.getFileIdFromLogPath(logFiles.get(0).getPath());
+ LOG.info("Finished scanning log files. FileId: {}, BaseInstantTime:
{}, "
Review Comment:
This is not addressed. In table version 9, the instant time extracted from
the log file reflect the delta commit time, not the base file instant time, so
`BaseInstantTime` is confusing. I suggest to make it `LogFileInstantTime`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
