CTTY commented on code in PR #17572: URL: https://github.com/apache/hudi/pull/17572#discussion_r2612397972
########## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieSparkClientTestHarness.java: ########## @@ -85,7 +86,6 @@ import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.TestInfo; -import org.slf4j.Logger; import org.slf4j.LoggerFactory; Review Comment: Should we remove the LoggerFactory as well? ########## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/HoodieWriteResult.java: ########## @@ -28,6 +32,10 @@ /** * Result of a write operation. */ +@AllArgsConstructor +@Getter +@Setter +@ToString Review Comment: This can be `@Data` ########## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/HoodieBloomFilterProbingResult.java: ########## @@ -19,17 +19,14 @@ package org.apache.hudi.index.bloom; +import lombok.AllArgsConstructor; +import lombok.Getter; + import java.util.List; +@AllArgsConstructor +@Getter Review Comment: This can be `@Value` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
