shubhampatel28 commented on code in PR #14354:
URL: https://github.com/apache/hudi/pull/14354#discussion_r2613326761
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -390,7 +400,13 @@ private void ensurePartitionsLoadedCorrectly(List<String>
partitionList) {
long beginTs = System.currentTimeMillis();
// Not loaded yet
try {
- LOG.debug("Building file system view for partitions: {}",
partitionSet);
+ // For metadata table, always log at DEBUG. For data table, log at
INFO once every 10 times
+ if (metaClient.isMetadataTable()) {
+ LOG.debug("Building file system view for partitions: {}",
partitionSet);
+ } else {
+ partitionViewBuildSamplingLogger.logInfoOrDebug(
+ "Building file system view for partitions: {}", partitionSet);
+ }
Review Comment:
updated to show partition size
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -390,7 +400,13 @@ private void ensurePartitionsLoadedCorrectly(List<String>
partitionList) {
long beginTs = System.currentTimeMillis();
// Not loaded yet
try {
- LOG.debug("Building file system view for partitions: {}",
partitionSet);
+ // For metadata table, always log at DEBUG. For data table, log at
INFO once every 10 times
+ if (metaClient.isMetadataTable()) {
+ LOG.debug("Building file system view for partitions: {}",
partitionSet);
+ } else {
+ partitionViewBuildSamplingLogger.logInfoOrDebug(
+ "Building file system view for partitions: {}", partitionSet);
+ }
Review Comment:
updated to show partition size as that will be more useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
