yihua commented on code in PR #17586:
URL: https://github.com/apache/hudi/pull/17586#discussion_r2615998229
##########
hudi-common/src/test/java/org/apache/hudi/common/util/io/TestByteBufferBackedInputStream.java:
##########
@@ -38,20 +40,20 @@ public void testConstructor() {
ByteBuffer byteBufClone = byteBuf.duplicate();
// ByteBuffer ctor
- ByteBufferBackedInputStream first = new
ByteBufferBackedInputStream(byteBuf);
+ org.apache.hudi.io.ByteBufferBackedInputStream first = new
org.apache.hudi.io.ByteBufferBackedInputStream(byteBuf);
Review Comment:
No need of package prefix?
##########
hudi-common/src/test/java/org/apache/hudi/common/util/io/TestByteBufferBackedInputStream.java:
##########
@@ -38,20 +40,20 @@ public void testConstructor() {
ByteBuffer byteBufClone = byteBuf.duplicate();
// ByteBuffer ctor
- ByteBufferBackedInputStream first = new
ByteBufferBackedInputStream(byteBuf);
+ org.apache.hudi.io.ByteBufferBackedInputStream first = new
org.apache.hudi.io.ByteBufferBackedInputStream(byteBuf);
assertEquals(first.read(), 0xD);
assertThrows(IllegalArgumentException.class, first::read);
// Make sure that the original buffer stays intact
assertEquals(byteBufClone, byteBuf);
// byte[] ctor
- ByteBufferBackedInputStream second = new
ByteBufferBackedInputStream(bytes);
+ org.apache.hudi.io.ByteBufferBackedInputStream second = new
org.apache.hudi.io.ByteBufferBackedInputStream(bytes);
Review Comment:
Same here and other similar lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
