yihua commented on code in PR #17573: URL: https://github.com/apache/hudi/pull/17573#discussion_r2616084557
########## hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala: ########## @@ -49,13 +49,13 @@ import scala.collection.JavaConverters._ * * PLEASE REFRAIN MAKING ANY CHANGES TO THIS CODE UNLESS ABSOLUTELY NECESSARY */ -private[sql] class AvroDeserializer(rootAvroType: Schema, +private[sql] class AvroDeserializer(rootAvroType: HoodieSchema, Review Comment: As discussed offline, given that the `AvroSerializer`, `AvroDeserializer`, and other relevant classes are used to do conversion between `GenericRecord` / `IndexedRecord` and Spark Rows, it is better to keep these classes intact by taking Avro schema as they are needed for Avro serde, and there is little value using `HoodieSchema` inside these classes. The callers can take `HoodieSchema` and pass in the converted Avro schema to these classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
