yihua commented on code in PR #17524:
URL: https://github.com/apache/hudi/pull/17524#discussion_r2616111300
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java:
##########
@@ -79,54 +81,6 @@ static class Heartbeat {
private Integer numHeartbeats = 0;
private Timer timer = new Timer(true);
- public String getInstantTime() {
- return instantTime;
- }
-
- public void setInstantTime(String instantTime) {
- this.instantTime = instantTime;
- }
-
- public Boolean isHeartbeatStarted() {
- return isHeartbeatStarted;
- }
-
- public void setHeartbeatStarted(Boolean heartbeatStarted) {
- isHeartbeatStarted = heartbeatStarted;
- }
-
- public Boolean isHeartbeatStopped() {
- return isHeartbeatStopped;
Review Comment:
Could we rename the variables `isHeartbeatStarted` -> `heartbeatStarted`,
`isHeartbeatStopped` -> `heartbeatStopped`, so that lombok auto-generates the
same methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
