CTTY commented on code in PR #17588:
URL: https://github.com/apache/hudi/pull/17588#discussion_r2617448620
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/client/TestJavaHoodieBackedMetadata.java:
##########
@@ -119,7 +120,6 @@
import org.junit.jupiter.params.provider.EnumSource;
import org.junit.jupiter.params.provider.MethodSource;
import org.junit.jupiter.params.provider.ValueSource;
-import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Review Comment:
Should we remove the `LoggerFactory` as well?
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/JavaSortAndSizeExecutionStrategy.java:
##########
@@ -57,7 +56,7 @@ public List<WriteStatus> performClusteringWithRecordList(
final List<HoodieRecord<T>> inputRecords, final int numOutputGroups,
final String instantTime, final Map<String, String> strategyParams,
final Schema schema,
final List<HoodieFileGroupId> fileGroupIdList, final boolean
preserveHoodieMetadata) {
- LOG.info("Starting clustering for a group, parallelism:" + numOutputGroups
+ " commit:" + instantTime);
+ log.info("Starting clustering for a group, parallelism:" + numOutputGroups
+ " commit:" + instantTime);
Review Comment:
nit: it would be better if we just go with parameterized logging:
```
log.info("Starting clustering for a group, parallelism:{} commit:{}",
numOutputGroups, instantTime);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
