rahil-c commented on code in PR #17573:
URL: https://github.com/apache/hudi/pull/17573#discussion_r2620864967
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -841,13 +840,13 @@ object HoodieBaseRelation extends SparkAdapterSupport {
val requiredRowSchema = requiredDataSchema.structTypeSchema
// NOTE: Schema has to be parsed at this point, since Avro's [[Schema]]
aren't serializable
// to be passed from driver to executor
- val requiredAvroSchema = new
Schema.Parser().parse(requiredDataSchema.avroSchemaStr)
- val avroToRowConverter =
AvroConversionUtils.createAvroToInternalRowConverter(requiredAvroSchema,
requiredRowSchema)
+ val requiredSchema = HoodieSchema.parse(requiredDataSchema.avroSchemaStr)
+ //TODO to fill impl for this
Review Comment:
This comment actually can be removed as its been addressed. Since we now
have added a util
`HoodieSchemaConversionUtils.createGenericRecordToInternalRowConverter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
