danny0405 commented on code in PR #17562: URL: https://github.com/apache/hudi/pull/17562#discussion_r2625427866
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/split/HoodieContinuousSplitBatch.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.source.split; + +import org.apache.hudi.common.util.ValidationUtils; + +import java.util.Collection; +import java.util.Collections; + +/** + * Result from continuous enumerator. + */ +public class HoodieContinuousSplitBatch { + public static final HoodieContinuousSplitBatch EMPTY = new HoodieContinuousSplitBatch(Collections.emptyList(), "", ""); + private final Collection<HoodieSourceSplit> splits; + private final String fromInstant; + private final String toInstant; + + /** + * @param splits should never be null. But it can be an empty collection + * @param fromInstant could be null + * @param toInstant should never be null. But it can be empty string + */ + public HoodieContinuousSplitBatch( + Collection<HoodieSourceSplit> splits, + String fromInstant, Review Comment: if these two are setup into `position` for next read, then they should just be setup as `endInstant` and `offset` from `IncrementalInputSplits.Result`. the `offset` is a completion time and should be the next inc query start point(exclusive). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
