danny0405 commented on code in PR #17607:
URL: https://github.com/apache/hudi/pull/17607#discussion_r2629336066


##########
hudi-common/src/main/java/org/apache/hudi/common/table/cdc/HoodieCDCExtractor.java:
##########
@@ -341,6 +341,20 @@ private Option<FileSlice> getDependentFileSliceForLogFile(
               .filter(logFile -> !logFile.equals(currentLogFileName))
               .map(logFile -> new StoragePath(partitionPath, logFile))
               .collect(Collectors.toList());
+          // get files list from unfinished compaction commit
+          List<StoragePath> filesToCompact = 
metaClient.getActiveTimeline().getInstants().stream().filter(
+                  i -> i.compareTo(instant) < 0 && !i.isCompleted() && 
i.getAction()
+                      .equals(HoodieActiveTimeline.COMPACTION_ACTION))

Review Comment:
   > because base file or CDC file of that base file will be parsed correctly 
in parseWriteStat function on it's own instant.
   
   @kamronis can you point to the link of the line of code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to