cshuo commented on code in PR #13417:
URL: https://github.com/apache/hudi/pull/13417#discussion_r2629378892
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkStreamWriteMetrics.java:
##########
@@ -66,6 +66,11 @@ public class FlinkStreamWriteMetrics extends
HoodieFlinkMetrics {
*/
private long numOfFilesWritten;
+ /**
+ * Number of record write failure during a checkpoint window.
+ */
+ private long numOfRecordWriteFailures;
Review Comment:
should also registers it in `registerMetrics`.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkStreamWriteMetrics.java:
##########
@@ -132,6 +137,14 @@ public void increaseNumOfFilesWritten() {
numOfFilesWritten += 1;
}
+ public void addNumOfRecordWriteFailure(long recordWriteFailures) {
Review Comment:
follow the naming of other methods, `addNum..` -> `increaseNum`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
