vamsikarnika commented on code in PR #17463: URL: https://github.com/apache/hudi/pull/17463#discussion_r2627851168
########## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/ShowFileHistoryProcedureUtils.scala: ########## @@ -0,0 +1,481 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.hudi.command.procedures + +import org.apache.hudi.common.model.{HoodieCommitMetadata, HoodieWriteStat, WriteOperationType} +import org.apache.hudi.common.table.HoodieTableMetaClient +import org.apache.hudi.common.table.timeline.{HoodieInstant, HoodieTimeline} +import org.apache.hudi.common.util.ClusteringUtils + +import org.apache.spark.internal.Logging +import org.apache.spark.sql.types.{DataTypes, Metadata, StructField, StructType} + +import java.util + +import scala.collection.JavaConverters._ + +case class HistoryEntry(instantTime: String, + completionTime: String, + action: String, + timelineType: String, + state: String, + partitionPath: String, + fileName: String, + operationType: String, + numWrites: Long, + numInserts: Long, + numUpdates: Long, + numDeletes: Long, + fileSizeBytes: Long, + totalWriteBytes: Long, + prevCommit: String, + totalWriteErrors: Long, + totalScanTimeMs: Long, + totalUpsertTimeMs: Long, + totalCreateTimeMs: Long, + prevBaseFile: Option[String], + columnStatsAvailable: Boolean + ) + +case class DeletionInfo(action: String, instant: String, timelineType: String, deleteStatus: String = "SUCCESS") + +case class ReplacementInfo(action: String, instant: String, timelineType: String) + +object ShowFileHistoryProcedureUtils extends Logging { + + val OUTPUT_TYPE = new StructType(Array[StructField]( + StructField("instant_time", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("completion_time", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("action", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("timeline_type", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("state", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("partition_path", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("file_name", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("operation_type", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("num_writes", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("num_inserts", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("num_updates", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("num_deletes", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("file_size_bytes", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("total_write_bytes", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("prev_commit", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("was_deleted", DataTypes.BooleanType, nullable = true, Metadata.empty), + StructField("delete_action", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("delete_instant", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("delete_status", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("was_replaced", DataTypes.BooleanType, nullable = true, Metadata.empty), + StructField("replace_action", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("replace_instant", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("total_write_errors", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("total_scan_time_ms", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("total_upsert_time_ms", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("total_create_time_ms", DataTypes.LongType, nullable = true, Metadata.empty), + StructField("prev_base_file", DataTypes.StringType, nullable = true, Metadata.empty), + StructField("column_stats_available", DataTypes.BooleanType, nullable = true, Metadata.empty) + )) + + def readCommitMetadata(timeline: HoodieTimeline, instant: HoodieInstant): Option[HoodieCommitMetadata] = { + try { + if (ClusteringUtils.isClusteringOrReplaceCommitAction(instant.getAction)) { + Option(timeline.readReplaceCommitMetadata(instant)) + } else { + Option(timeline.readCommitMetadata(instant)) + } + } catch { + case e: Exception => + log.warn(s"Failed to read commit metadata for ${instant.requestedTime}: ${e.getMessage}") + None + } + } + + def determineOperationType(writeStat: HoodieWriteStat): String = { + val hasInserts = writeStat.getNumInserts > 0 + val hasUpdates = writeStat.getNumUpdateWrites > 0 + val hasDeletes = writeStat.getNumDeletes > 0 + + val operations = Seq( + if (hasInserts) Some("INSERT") else None, + if (hasUpdates) Some("UPDATE") else None, + if (hasDeletes) Some("DELETE") else None + ).flatten + + if (operations.nonEmpty) { + operations.mkString("_AND_") + } else { + "UNKNOWN" + } + } + + def processWriteTimeline(timeline: HoodieTimeline, + fileGroupId: String, + targetPartition: Option[String], + timelineType: String, + entries: util.ArrayList[HistoryEntry], + limit: Int, + startTime: String, + endTime: String): Unit = { + + val writeTimeline = timeline.getWriteTimeline + val allInstants = writeTimeline.getInstants.asScala.toSeq + + val filteredInstants = if (startTime.nonEmpty && endTime.nonEmpty) { + allInstants.filter { instant => + val instantTime = instant.requestedTime() + instantTime >= startTime && instantTime <= endTime + } + } else if (startTime.nonEmpty) { + allInstants.filter { instant => + val instantTime = instant.requestedTime() + instantTime >= startTime + } + } else { + allInstants + } + + if (startTime.nonEmpty && endTime.nonEmpty) { + for (instant <- filteredInstants) { + try { + processInstant(timeline, instant, fileGroupId, targetPartition, timelineType, entries) + } catch { + case e: Exception => + log.warn(s"Failed to process instant ${instant.requestedTime}: ${e.getMessage}") + } + } + } else { + var foundCount = 0 + for (instant <- filteredInstants if foundCount < limit) { + try { + val initialSize = entries.size() + processInstant(timeline, instant, fileGroupId, targetPartition, timelineType, entries) + if (entries.size() > initialSize) { + foundCount += 1 + } + } catch { + case e: Exception => + log.warn(s"Failed to process instant ${instant.requestedTime}: ${e.getMessage}") + } + } + } + } + + private def processInstant(timeline: HoodieTimeline, + instant: HoodieInstant, + fileGroupId: String, + targetPartition: Option[String], + timelineType: String, + entries: util.ArrayList[HistoryEntry]): Unit = { + + if (instant.getState == HoodieInstant.State.INFLIGHT || instant.getState == HoodieInstant.State.REQUESTED) { + val entry = createInflightRequestedEntry(instant, targetPartition, timelineType) + entries.add(entry) Review Comment: Do we need to show these requested/inflight instants, since we're not sure if this instant actually touches the provided file group? I think It can be confusing to the user -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
