rahil-c commented on code in PR #17573:
URL: https://github.com/apache/hudi/pull/17573#discussion_r2632579394
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestDataSourceDefaults.scala:
##########
@@ -625,14 +624,14 @@ class TestDataSourceDefaults extends
ScalaAssertionSupport {
val props = new TypedProperties()
OrderingFieldsTestUtils.setOrderingFieldsConfig(props, key,
"favoriteIntNumber")
val baseOrderingVal: Object = baseRecord.get("favoriteIntNumber")
- val fieldSchema: Schema =
baseRecord.getSchema().getField("favoriteIntNumber").schema()
+ val fieldSchema: HoodieSchema =
HoodieSchema.fromAvroSchema(baseRecord.getSchema().getField("favoriteIntNumber").schema())
- val basePayload = new OverwriteWithLatestAvroPayload(baseRecord,
HoodieAvroUtils.convertValueForSpecificDataTypes(fieldSchema, baseOrderingVal,
false).asInstanceOf[Comparable[_]])
+ val basePayload = new OverwriteWithLatestAvroPayload(baseRecord,
org.apache.hudi.common.schema.HoodieSchemaUtils.convertValueForSpecificDataTypes(fieldSchema,
baseOrderingVal, false).asInstanceOf[Comparable[_]])
Review Comment:
@yihua recommend to use scala import to give a different to avoid using a
package prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
