xushiyan commented on code in PR #13259:
URL: https://github.com/apache/hudi/pull/13259#discussion_r2633212854
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/util/FlinkClientUtil.java:
##########
@@ -56,6 +67,22 @@ public static org.apache.hadoop.conf.Configuration
getHadoopConf() {
if (hadoopConf == null) {
hadoopConf = new org.apache.hadoop.conf.Configuration();
}
+
+ String confDir = System.getenv(FLINK_CONF_DIR);
+ if (StringUtils.isNullOrEmpty(confDir)) {
+ confDir = System.getenv(ApplicationConstants.Environment.PWD.key());
Review Comment:
i think we should be ok to add loading from `FLINK_CONF_DIR` and flag this
as a behavior change. but loading from `PWD` is risky, like a random
`core-site.xml` placed in `PWD` could be loaded implicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
