yihua commented on code in PR #17573:
URL: https://github.com/apache/hudi/pull/17573#discussion_r2633385786
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/cdc/TestCDCDataFrameSuite.scala:
##########
@@ -21,6 +21,7 @@ package org.apache.hudi.functional.cdc
import org.apache.hudi.DataSourceWriteOptions
import org.apache.hudi.DataSourceWriteOptions.{MOR_TABLE_TYPE_OPT_VAL,
PARTITIONPATH_FIELD_OPT_KEY, PRECOMBINE_FIELD_OPT_KEY, RECORDKEY_FIELD_OPT_KEY}
import org.apache.hudi.QuickstartUtils.getQuickstartWriteConfigs
+import org.apache.hudi.common.schema.HoodieSchema
Review Comment:
nit: This import is redundant
##########
hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/avro/HoodieSpark3_3AvroSerializer.scala:
##########
@@ -17,13 +17,14 @@
package org.apache.spark.sql.avro
-import org.apache.avro.Schema
+import org.apache.hudi.common.schema.HoodieSchema
+
import org.apache.spark.sql.types.DataType
-class HoodieSpark3_3AvroSerializer(rootCatalystType: DataType, rootAvroType:
Schema, nullable: Boolean)
+class HoodieSpark3_3AvroSerializer(rootCatalystType: DataType, rootType:
HoodieSchema, nullable: Boolean)
Review Comment:
Same here
##########
hudi-spark-datasource/hudi-spark3.5.x/src/main/scala/org/apache/spark/sql/avro/HoodieSpark3_5AvroSerializer.scala:
##########
@@ -17,6 +17,8 @@
package org.apache.spark.sql.avro
+import org.apache.hudi.common.schema.HoodieSchema
Review Comment:
nit: import is unnecessary
##########
hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/avro/HoodieSpark3_3AvroDeserializer.scala:
##########
@@ -17,15 +17,16 @@
package org.apache.spark.sql.avro
-import org.apache.avro.Schema
+import org.apache.hudi.common.schema.HoodieSchema
+
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.internal.SQLConf.LegacyBehaviorPolicy
import org.apache.spark.sql.types.DataType
-class HoodieSpark3_3AvroDeserializer(rootAvroType: Schema, rootCatalystType:
DataType)
+class HoodieSpark3_3AvroDeserializer(rootType: HoodieSchema, rootCatalystType:
DataType)
Review Comment:
Look like the logic in Spark 3.3 is not fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
