yihua commented on code in PR #17637:
URL: https://github.com/apache/hudi/pull/17637#discussion_r2636179887
##########
.github/workflows/bot.yml:
##########
@@ -1015,15 +1015,6 @@ jobs:
sudo chown -R "$USER:$(id -g -n)"
hudi-platform-service/hudi-metaserver/target/generated-sources
mvn clean package -T 2 -D"$SCALA_PROFILE" -D"$FLINK_PROFILE"
-DdeployArtifacts=true -DskipTests=true $MVN_ARGS -pl
packaging/hudi-flink-bundle -am -Davro.version="$FLINK_AVRO_VERSION"
-Dparquet.version="$FLINK_PARQUET_VERSION"
-Dparquet.version="$FLINK_PARQUET_VERSION"
fi
- - name: IT - Bundle Validation - OpenJDK 8
Review Comment:
The bundle validation on Java 8 should also be removed from
`.github/workflows/maven_artifact_validation.yml` and
`.github/workflows/release_candidate_validation.yml`.
##########
packaging/bundle-validation/validate.sh:
##########
@@ -300,10 +300,7 @@ test_metaserver_bundle () {
##
test_cli_bundle() {
echo "::warning::validate.sh setting up CLI bundle validation"
-
- if [ "$SPARK_VERSION" = "4.0.0" ]; then
- change_java_runtime_version
- fi
+ change_java_runtime_version
Review Comment:
L414 on master should be changed to run Flink bundle validation.
```
if [[ ${JAVA_RUNTIME_VERSION} == 'openjdk8' && ${SCALA_PROFILE} !=
'scala-2.13' ]]; then
```
##########
pom.xml:
##########
@@ -1901,7 +1914,10 @@
</execution>
</executions>
<configuration>
+ <source>11</source>
<doclint>none</doclint>
+ <failOnWarnings>false</failOnWarnings>
+ <failOnError>false</failOnError>
Review Comment:
Let's add a Github issue to track the issue of generating Javadocs.
##########
.github/workflows/bot.yml:
##########
@@ -1136,59 +1127,59 @@ jobs:
HUDI_VERSION=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
./packaging/bundle-validation/ci_run.sh hudi_docker_java17
$HUDI_VERSION openjdk17
-# validate-bundles-java11:
-# runs-on: ubuntu-latest
-# strategy:
-# matrix:
-# include:
-# - scalaProfile: 'scala-2.13'
-# flinkProfile: 'flink1.20'
-# sparkProfile: 'spark3.5'
-# sparkRuntime: 'spark3.5.0'
-# - scalaProfile: 'scala-2.12'
-# flinkProfile: 'flink1.20'
-# sparkProfile: 'spark3.5'
-# sparkRuntime: 'spark3.5.0'
-# steps:
-# - uses: actions/checkout@v3
-# - name: Set up JDK 11
-# uses: actions/setup-java@v3
-# with:
-# java-version: '11'
-# distribution: 'temurin'
-# architecture: x64
-# - name: Build Project
-# env:
-# FLINK_PROFILE: ${{ matrix.flinkProfile }}
-# SPARK_PROFILE: ${{ matrix.sparkProfile }}
-# SCALA_PROFILE: ${{ matrix.scalaProfile }}
-# run: |
-# if [ "$SCALA_PROFILE" == "scala-2.13" ]; then
-# mvn clean package -T 2 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE"
-DdeployArtifacts=true -DskipTests=true $MVN_ARGS -Dmaven.javadoc.skip=true -pl
packaging/hudi-hadoop-mr-bundle,packaging/hudi-spark-bundle,packaging/hudi-utilities-bundle,packaging/hudi-utilities-slim-bundle
-am
-# else
-# mvn clean package -T 2 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE"
-DdeployArtifacts=true -DskipTests=true $MVN_ARGS -Dmaven.javadoc.skip=true
-# # TODO remove the sudo below. It's a needed workaround as
detailed in HUDI-5708.
-# sudo chown -R "$USER:$(id -g -n)"
hudi-platform-service/hudi-metaserver/target/generated-sources
-# mvn clean package -T 2 -D"$SCALA_PROFILE" -D"$FLINK_PROFILE"
-DdeployArtifacts=true -DskipTests=true $MVN_ARGS -Dmaven.javadoc.skip=true -pl
packaging/hudi-flink-bundle -am -Davro.version=1.10.0
-# fi
-# - name: IT - Bundle Validation - OpenJDK 11
-# env:
-# FLINK_PROFILE: ${{ matrix.flinkProfile }}
-# SPARK_PROFILE: ${{ matrix.sparkProfile }}
-# SPARK_RUNTIME: ${{ matrix.sparkRuntime }}
-# SCALA_PROFILE: ${{ matrix.scalaProfile }}
-# run: |
-# HUDI_VERSION=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
-# ./packaging/bundle-validation/ci_run.sh hudi_docker_java11
$HUDI_VERSION openjdk11
-# - name: IT - Bundle Validation - OpenJDK 17
-# env:
-# FLINK_PROFILE: ${{ matrix.flinkProfile }}
-# SPARK_PROFILE: ${{ matrix.sparkProfile }}
-# SPARK_RUNTIME: ${{ matrix.sparkRuntime }}
-# SCALA_PROFILE: ${{ matrix.scalaProfile }}
-# run: |
-# HUDI_VERSION=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
-# ./packaging/bundle-validation/ci_run.sh hudi_docker_java17
$HUDI_VERSION openjdk17
+ # validate-bundles-java11:
+ # runs-on: ubuntu-latest
+ # strategy:
+ # matrix:
+ # include:
+ # - scalaProfile: 'scala-2.13'
+ # flinkProfile: 'flink1.20'
+ # sparkProfile: 'spark3.5'
+ # sparkRuntime: 'spark3.5.0'
+ # - scalaProfile: 'scala-2.12'
+ # flinkProfile: 'flink1.20'
+ # sparkProfile: 'spark3.5'
+ # sparkRuntime: 'spark3.5.0'
+ # steps:
+ # - uses: actions/checkout@v5
+ # - name: Set up JDK 11
+ # uses: actions/setup-java@v5
+ # with:
+ # java-version: '11'
+ # distribution: 'temurin'
+ # architecture: x64
+ # - name: Build Project
+ # env:
+ # FLINK_PROFILE: ${{ matrix.flinkProfile }}
+ # SPARK_PROFILE: ${{ matrix.sparkProfile }}
+ # SCALA_PROFILE: ${{ matrix.scalaProfile }}
+ # run: |
+ # if [ "$SCALA_PROFILE" == "scala-2.13" ]; then
+ # mvn clean package -T 2 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE"
-DdeployArtifacts=true -DskipTests=true $MVN_ARGS -Dmaven.javadoc.skip=true -pl
packaging/hudi-hadoop-mr-bundle,packaging/hudi-spark-bundle,packaging/hudi-utilities-bundle,packaging/hudi-utilities-slim-bundle
-am
+ # else
+ # mvn clean package -T 2 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE"
-DdeployArtifacts=true -DskipTests=true $MVN_ARGS -Dmaven.javadoc.skip=true
+ # # TODO remove the sudo below. It's a needed workaround as
detailed in HUDI-5708.
+ # sudo chown -R "$USER:$(id -g -n)"
hudi-platform-service/hudi-metaserver/target/generated-sources
+ # mvn clean package -T 2 -D"$SCALA_PROFILE" -D"$FLINK_PROFILE"
-DdeployArtifacts=true -DskipTests=true $MVN_ARGS -Dmaven.javadoc.skip=true -pl
packaging/hudi-flink-bundle -am -Davro.version=1.10.0
+ # fi
+ # - name: IT - Bundle Validation - OpenJDK 11
+ # env:
+ # FLINK_PROFILE: ${{ matrix.flinkProfile }}
+ # SPARK_PROFILE: ${{ matrix.sparkProfile }}
+ # SPARK_RUNTIME: ${{ matrix.sparkRuntime }}
+ # SCALA_PROFILE: ${{ matrix.scalaProfile }}
+ # run: |
+ # HUDI_VERSION=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
+ # ./packaging/bundle-validation/ci_run.sh hudi_docker_java11
$HUDI_VERSION openjdk11
+ # - name: IT - Bundle Validation - OpenJDK 17
+ # env:
+ # FLINK_PROFILE: ${{ matrix.flinkProfile }}
+ # SPARK_PROFILE: ${{ matrix.sparkProfile }}
+ # SPARK_RUNTIME: ${{ matrix.sparkRuntime }}
+ # SCALA_PROFILE: ${{ matrix.scalaProfile }}
+ # run: |
+ # HUDI_VERSION=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
+ # ./packaging/bundle-validation/ci_run.sh hudi_docker_java17
$HUDI_VERSION openjdk17
Review Comment:
We can remove this block of scripts now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
