voonhous commented on code in PR #17655:
URL: https://github.com/apache/hudi/pull/17655#discussion_r2636885971


##########
hudi-common/src/main/java/org/apache/hudi/internal/schema/InternalSchema.java:
##########
@@ -144,20 +146,6 @@ public long schemaId() {
     return this.versionId;
   }

Review Comment:
   We could change this field to `schemaId`, and rename this function to 
`getSchemaId` (which will be generated by `@Getter`), but I'm afraid of 
exploding this PR. So am gonna retain this for now. We can circle back later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to