VahidRamezaniDB commented on code in PR #17645:
URL: https://github.com/apache/hudi/pull/17645#discussion_r2637167766


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/CompletionTimeQueryView.java:
##########
@@ -97,13 +97,13 @@ List<String> getInstantTimes(
 
   /**
    *  Get Cursor Instant
-   * @return
+   * @return {@link String}

Review Comment:
   changed it at 9b196b334610457ee964e4f40f2a07d9b04f14d8



##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -46,7 +46,7 @@ public interface HoodieActiveTimeline extends HoodieTimeline {
 
   /**
    * Return Valid extensions expected in active timeline.
-   * @return
+   * @return {@link Set<String>}

Review Comment:
   changed it at 9b196b334610457ee964e4f40f2a07d9b04f14d8



##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -434,7 +434,7 @@ public interface HoodieActiveTimeline extends 
HoodieTimeline {
 
   /**
    * Valid Extensions in active timeline.
-   * @return
+   * @return {@link Set<String>}

Review Comment:
   changed it at 9b196b334610457ee964e4f40f2a07d9b04f14d8



##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/InstantComparator.java:
##########
@@ -25,19 +25,19 @@ public interface InstantComparator extends Serializable {
 
   /**
    * Returns Comparator that only uses action for ordering taking into account 
equivalent actions.
-   * @return
+   * @return {@link Comparator<HoodieInstant>}
    */
   Comparator<HoodieInstant> actionOnlyComparator();
 
   /**
    * Returns comparator that orders primarily based on timestamp and secondary 
ordering based on action and state.
-   * @return
+   * @return {@link Comparator<HoodieInstant>}
    */
   Comparator<HoodieInstant> requestedTimeOrderedComparator();
 
   /**
    * Returns comparator that orders primarily based on completion time and 
secondary ordering based on {@link #requestedTimeOrderedComparator()}.
-   * @return
+   * @return {@link Comparator<HoodieInstant>}

Review Comment:
   changed it at 9b196b334610457ee964e4f40f2a07d9b04f14d8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to