voonhous commented on code in PR #17662:
URL: https://github.com/apache/hudi/pull/17662#discussion_r2638573586
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/ParquetBinaryCopyChecker.java:
##########
@@ -215,37 +216,20 @@ private static boolean
schemaNotSupportBinaryCopy(List<Type> parquetFields) {
return false;
}
+ @AllArgsConstructor
public static class ParquetFileInfo implements Serializable {
- private final boolean canBinaryCopy;
- private final String bloomFilterTypeCode;
- private final String schema;
-
- public ParquetFileInfo(boolean canBinaryCopy, String
hoodieBloomFilterTypeCode, String schema) {
- this.canBinaryCopy = canBinaryCopy;
- this.bloomFilterTypeCode = hoodieBloomFilterTypeCode;
- this.schema = schema;
- }
/**
* Current file can use binary copy or not
* Following two case can not support
* 1. two level List structure, because the result of parquet rewrite is
three level List structure
* 2. Decimal types stored via INT32/INT64/INT96, because it can not be
read by parquet-avro
- *
- * @param parquetFields
- * @return
*/
- public boolean canBinaryCopy() {
- return canBinaryCopy;
- }
-
- public String getBloomFilterTypeCode() {
- return bloomFilterTypeCode;
- }
-
- public String getSchema() {
- return schema;
- }
+ @Getter
Review Comment:
Moved!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]