voonhous opened a new pull request, #17672:
URL: https://github.com/apache/hudi/pull/17672
…n HoodieMetadataPayload
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
Linked issue: https://github.com/apache/hudi/issues/17532
Restore O(1) reference equality comparison without changing the public
interface of `HoodieRecordPayload`.
**Explanation of changes:**
1. Add `HOODIE_METADATA_AVRO_SCHEMA` as a **static final field**, so it's
always the same reference
2. When `HoodieSchemaCache.intern()` is called elsewhere with the metadata
schema, and then `.toAvroSchema()` is called on it, it **WILL** return the same
underlying Avro Schema object reference (assuming `HoodieSchemaCache.intern()`
caches the wrapper and the wrapper holds the same Avro Schema reference)
3. This restores O(1) reference equality checks
We initially planned for the migration path of adding this O(1) check back
after `HoodieRecordPayload.getInsertValue()` is updated to accept
`HoodieSchema` instead of `Schema`. However, after checking the scope of
change, I feel this should be 2 separate tasks as:
1. We should not block performance impacts unnecessarily given that the same
behaviour is only a few lines of changes
2. `HoodieRecordPayload` is a public API and hence is a high- risk task.
- Changes here will affect payload records that are not maintained in
our repo, careful planning needs to be done.
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
1. Added a cached Avro Schema reference
4. Updated the schema comparison
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
None
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
None
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
