yihua commented on code in PR #17668:
URL: https://github.com/apache/hudi/pull/17668#discussion_r2641600799
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java:
##########
@@ -282,6 +285,13 @@ protected void processNextDeletedRecord(DeleteRecord
deleteRecord) {
Comparable curOrderingVal =
oldRecord.getOrderingValue(this.readerSchema,
this.hoodieTableMetaClient.getTableConfig().getProps());
Comparable deleteOrderingVal = deleteRecord.getOrderingValue();
+ if (curOrderingVal instanceof Utf8){
Review Comment:
The payload classes are deprecated now
(https://hudi.apache.org/releases/release-1.1.0#deprecation-of-hoodierecordpayload)
and the old log record scanner is going to be removed. The new reader path
with merge modes can handle the event time-based merging correctly. @cbg-wx
could you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
