yihua commented on code in PR #17667:
URL: https://github.com/apache/hudi/pull/17667#discussion_r2641618786
##########
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/generator/DeltaGenerator.java:
##########
@@ -88,13 +88,13 @@ public DeltaGenerator(DFSDeltaConfig deltaOutputConfig,
JavaSparkContext jsc, Sp
}
public Pair<Integer, JavaRDD<DeltaWriteStats>>
writeRecords(JavaRDD<GenericRecord> records) {
- if (deltaOutputConfig.shouldDeleteOldInputData() && batchId > 1) {
+ if (deltaOutputConfig.isShouldDeleteOldInputData() && batchId > 1) {
Review Comment:
`isShouldDeleteOldInputData`: the name does not read well. Could it be
renamed to `isOldInputDataDeleted` based on `oldInputDataDeleted`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
