voonhous commented on code in PR #17581:
URL: https://github.com/apache/hudi/pull/17581#discussion_r2641751980
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HiveAvroSerializer.java:
##########
@@ -75,17 +76,16 @@ public class HiveAvroSerializer {
private final List<String> columnNames;
private final List<TypeInfo> columnTypes;
private final ArrayWritableObjectInspector objectInspector;
- private final Schema recordSchema;
+ private final HoodieSchema recordSchema;
private static final Logger LOG =
LoggerFactory.getLogger(HiveAvroSerializer.class);
- public HiveAvroSerializer(Schema schema) {
- schema = AvroSchemaUtils.getNonNullTypeFromUnion(schema);
Review Comment:
It's still used in the test
`org.apache.hudi.common.schema.TestHoodieSchemaUtils#testResolveUnionSchemaConsistencyWithOriginalAvroImpl`
to ensure consistency between the `Avro.Schema` and `HoodieSchema`
implementation
I can remove this entirely within this PR if you're alright with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
