voonhous commented on code in PR #17599:
URL: https://github.com/apache/hudi/pull/17599#discussion_r2643568881
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/AvroOrcUtils.java:
##########
@@ -810,74 +812,65 @@ private static Schema getActualSchemaType(Schema
unionSchema) {
}
}
- public static Schema createAvroSchemaWithDefaultValue(TypeDescription
orcSchema, String recordName, String namespace, boolean nullable) {
- Schema avroSchema =
createAvroSchemaWithNamespace(orcSchema,recordName,namespace);
- List<Schema.Field> fields = new ArrayList<Schema.Field>();
- List<Field> fieldList = avroSchema.getFields();
- for (Field field : fieldList) {
- Schema fieldSchema = field.schema();
- Schema nullableSchema =
Schema.createUnion(Schema.create(Schema.Type.NULL),fieldSchema);
+ public static HoodieSchema createSchemaWithDefaultValue(TypeDescription
orcSchema, String recordName, String namespace, boolean nullable) {
+ HoodieSchema hoodieSchema =
createSchemaWithNamespace(orcSchema,recordName,namespace);
+ List<HoodieSchemaField> fields = new ArrayList<>();
Review Comment:
Done!,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
