yihua commented on PR #17680: URL: https://github.com/apache/hudi/pull/17680#issuecomment-3687720451
> Since we've migrated to Lombok, should we use `lombok.NonNull` instead? On a second thought, `lombok.NonNull` generates runtime null-checks which is different from current behavior of static analysis. So I think for this particular PR to unblock Spark 4.1 integration, we should stick to `javax.annotation.Nonnull` which is consistent across the code base. > Should we also take the chance to standardise the `@VisibleForTesting` usages, we are mainly using: > > * `org.apache.hudi.common.util.VisibleForTesting` > > But i see references to: > > * `org.apache.flink.annotation.VisibleForTesting` > * `com.google.common.annotations.VisibleForTesting` We should do a separate sweep, #17688 to track. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
