pengzhiwei2018 commented on a change in pull request #2350:
URL: https://github.com/apache/hudi/pull/2350#discussion_r553077554
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/TableSchemaResolver.java
##########
@@ -296,7 +296,7 @@ public MessageType convertAvroSchemaToParquet(Schema
schema) {
public static boolean isSchemaCompatible(Schema oldSchema, Schema newSchema)
{
if (oldSchema.getType() == newSchema.getType() && newSchema.getType() ==
Schema.Type.RECORD) {
// record names must match:
- if (!SchemaCompatibility.schemaNameEquals(oldSchema, newSchema)) {
+ if (!SchemaCompatibility.schemaNameEquals(newSchema, oldSchema)) {
Review comment:
Hi @nsivabalan @prashantwason ,I have test write a "int" type to "long"
type.It fails in the the schema validate .
However,I write a "long" to "int", it can pass the validate. So I think this
"reverse" here introduce some problem. I have rollback the "reverse" in
https://github.com/apache/hudi/pull/2334 and add some test case. It works well
now. Can you take a look when you have time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
