cshuo commented on code in PR #17713:
URL: https://github.com/apache/hudi/pull/17713#discussion_r2647001807
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java:
##########
@@ -282,11 +284,14 @@ protected void processNextDeletedRecord(DeleteRecord
deleteRecord) {
Comparable curOrderingVal =
oldRecord.getOrderingValue(this.readerSchema,
this.hoodieTableMetaClient.getTableConfig().getProps());
Comparable deleteOrderingVal = deleteRecord.getOrderingValue();
+ Pair<Comparable, Comparable> comparablePair =
OrderingValueUtils.canonicalizeOrderingValue(curOrderingVal, deleteOrderingVal);
+ curOrderingVal = comparablePair.getLeft();
+ deleteOrderingVal = comparablePair.getRight();
// Checks the ordering value does not equal to 0
// because we use 0 as the default value which means natural order
boolean choosePrev = !deleteOrderingVal.equals(0)
- && ReflectionUtils.isSameClass(curOrderingVal, deleteOrderingVal)
- && curOrderingVal.compareTo(deleteOrderingVal) > 0;
+ && ReflectionUtils.isSameClass(curOrderingVal,deleteOrderingVal)
Review Comment:
line 293 ~ 294 unnecessary changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
