n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553164370
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -232,17 +250,18 @@ void emitCommitMetrics(String instantTime,
HoodieCommitMetadata metadata, String
* Main API to run bootstrap to hudi.
*/
public void bootstrap(Option<Map<String, String>> extraMetadata) {
- if (rollbackPending) {
- rollBackInflightBootstrap();
- }
+ // TODO : MULTIWRITER -> check if failed bootstrap files can be cleaned
later
HoodieTable<T, I, K, O> table =
getTableAndInitCtx(WriteOperationType.UPSERT,
HoodieTimeline.METADATA_BOOTSTRAP_INSTANT_TS);
+ if (isEager(config.getFailedWritesCleanPolicy())) {
Review comment:
The `isEager` is needed for multiple operations, not just
`rollbackFailedBootstrap()`, changed it to do check within method but cannot do
operations inside eagerCleanFailedWrites. This will need more refactoring (if
possible), I can open a follow up ticket and take it up right after the release
to adhere against release timeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
