rahil-c commented on code in PR #17739:
URL: https://github.com/apache/hudi/pull/17739#discussion_r2651367282
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/model/HoodieFlinkRecord.java:
##########
@@ -193,14 +194,14 @@ public Object getColumnValueAsJava(Schema recordSchema,
String column, Propertie
private Object getColumnValueAsJava(Schema recordSchema, String column,
Properties props, boolean allowsNull) {
boolean utcTimezone = Boolean.parseBoolean(props.getProperty(
HoodieStorageConfig.WRITE_UTC_TIMEZONE.key(),
HoodieStorageConfig.WRITE_UTC_TIMEZONE.defaultValue().toString()));
- RowDataQueryContext rowDataQueryContext =
RowDataAvroQueryContexts.fromAvroSchema(recordSchema, utcTimezone);
+ RowDataQueryContext rowDataQueryContext =
RowDataQueryContexts.fromSchema(HoodieSchema.fromAvroSchema(recordSchema),
utcTimezone);
return rowDataQueryContext.getFieldQueryContext(column).getValAsJava(data,
allowsNull);
}
private Object getColumnValue(Schema recordSchema, String column, Properties
props) {
Review Comment:
Can we just change the param to take in `HoodieSchema` so that then in line
204 we dont have to do `fromAvroSchema`, or does this result in large changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
