nsivabalan commented on code in PR #17465:
URL: https://github.com/apache/hudi/pull/17465#discussion_r2651942555


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordPayload.java:
##########
@@ -162,6 +162,23 @@ default Comparable<?> getOrderingValue() {
     return 0;
   }
 
+  /**
+   * Returns true is this payload represents an actual record to be written.
+   *
+   * Default implementation checks if the insert value is present. For better 
write performance, this should be
+   * overridden by implementations for which generating the insert value is 
expensive.
+   *
+   * @param schema Schema used for record
+   * @param properties Payload related properties. For example pass the 
ordering field(s) name to extract from value in storage.
+   * @return true if this payload has a record to be written.
+   *         false if this payload is empty and should be skipped from writing.
+   *         false if this payload represents a record to be deleted.
+   */
+  @PublicAPIMethod(maturity = ApiMaturityLevel.EVOLVING)
+  default boolean hasInsertValue(Schema schema, Properties properties) throws 
IOException {

Review Comment:
   +1 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to