the-other-tim-brown commented on code in PR #17751:
URL: https://github.com/apache/hudi/pull/17751#discussion_r2653234604
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchema.java:
##########
@@ -478,6 +485,120 @@ public static HoodieSchema createUUID() {
return new HoodieSchema(uuidSchema);
}
+ /**
+ * Creates an unshredded Variant schema.
Review Comment:
General question, can you have shredded and unshredded values in the same
dataset? if so, it seems like the schema should be the same for these
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchemaType.java:
##########
@@ -150,6 +154,8 @@ public static HoodieSchemaType fromAvro(Schema avroSchema) {
return DATE;
} else if (logicalType == LogicalTypes.uuid()) {
return UUID;
+ } else if (logicalType instanceof VariantLogicalType) {
Review Comment:
Can we follow a similar pattern as the `uuid` where there is a singleton we
can compare to instead of instanceof?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
