linliu-code commented on code in PR #17601:
URL: https://github.com/apache/hudi/pull/17601#discussion_r2653278256
##########
hudi-common/src/main/java/org/apache/hudi/avro/ConvertingGenericData.java:
##########
@@ -57,12 +57,20 @@ private ConvertingGenericData() {
addLogicalTypeConversion(DATE_CONVERSION);
addLogicalTypeConversion(TIME_MICROS_CONVERSION);
addLogicalTypeConversion(TIMESTAMP_MICROS_CONVERSION);
- // NOTE: Those are not supported in Avro 1.8.2
- // TODO re-enable upon upgrading to 1.10
- // addLogicalTypeConversion(TIME_MILLIS_CONVERSION);
- // addLogicalTypeConversion(TIMESTAMP_MILLIS_CONVERSION);
- // addLogicalTypeConversion(LOCAL_TIMESTAMP_MILLIS_CONVERSION);
- // addLogicalTypeConversion(LOCAL_TIMESTAMP_MICROS_CONVERSION);
+ // NOTE: Those are not supported in Avro 1.8.2 (used by Spark 2)
+ // Only add conversions if they're available
Review Comment:
Right now we only make the conversion for Spark3.4+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
