the-other-tim-brown commented on code in PR #17731:
URL: https://github.com/apache/hudi/pull/17731#discussion_r2653829748


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/row/HoodieInternalRowFileWriterFactory.java:
##########
@@ -87,6 +92,19 @@ private static HoodieInternalRowFileWriter 
newParquetInternalRowFileWriter(Stora
         ));
   }
 
+  private static HoodieInternalRowFileWriter 
newLanceInternalRowFileWriter(StoragePath path,
+                                                                           
HoodieTable table,
+                                                                           
StructType structType)
+      throws IOException {
+    return new HoodieSparkLanceWriter(

Review Comment:
   Let's have a separate constructor defined for this usecase that does not 
take in the instant time or `populateMetaFields` option



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to