the-other-tim-brown opened a new pull request, #17770:
URL: https://github.com/apache/hudi/pull/17770
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
The CompletionTimeQueryViewV2 will load the completion times incrementally
and focus on loading the minimal set of files from the archived timeline. The
issue is that it will potentially load the same file multiple times since it
reads all entries from the file but only processes the instants in the provided
range.
The inefficiency is seen when loading the view for instant at time T2 then
at time T1. The LSMTimeline is read up to time T1 but only instants up to T2
are processed. The next request for T1 will re-read the file.
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
- Update the filtering to only apply at the file level
- Update the ArchivedTimelineLoader interface to return the earliest instant
time processed.
- Update the cursor to use the returned instant time
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
Makes loading the FileSystemView significantly more performant when there
are archived instants
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
Low
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
