Copilot commented on code in PR #509:
URL: https://github.com/apache/hudi-rs/pull/509#discussion_r2659439642
##########
.github/instructions/code-review.instructions.md:
##########
@@ -0,0 +1,159 @@
+---
+applyTo: "**/*"
+excludeAgents: ["coding-agent"]
+---
+
+# Code Review Instructions for Apache Hudi-rs
+
+## Multi-Round Review Behavior
+
+### Handling Subsequent Commits
+
+When reviewing a PR that has been updated with new commits after a previous
review:
+
+1. **Check if previous comments are addressed**:
+ - Compare the current code state against previous review comments
+ - If a comment has been addressed by new changes, acknowledge resolution
+ - Do NOT re-raise issues that have been fixed
+
+2. **Focus on incremental changes**:
+ - Prioritize reviewing code added or modified in the latest commits
+ - Identify any new issues introduced by the fixes
+ - Check if fixes introduced regressions elsewhere
+
+3. **Comment resolution signals**:
+ - If code now follows the suggested pattern → Comment is resolved
+ - If test coverage has been added as requested → Comment is resolved
+ - If documentation has been added → Comment is resolved
+ - If error handling has been improved → Comment is resolved
+
+4. **Acknowledge progress**:
+ - When significant improvements have been made, acknowledge them
+ - Be encouraging about progress while maintaining standards
+
+### Review Comment Format
+
+When leaving comments, use this severity classification:
+
+- **🔴 Critical**: Must fix before merge (correctness, safety, breaking changes)
+- **🟠 Important**: Should fix before merge (error handling, testing, docs)
+- **🟡 Suggestion**: Nice to have, not blocking (style, optimization)
+- **💬 Question**: Clarification needed, not necessarily an issue
Review Comment:
The severity classification uses emoji symbols that may not align with how
the `store_comment` tool actually works. The tool uses text-based severity
levels ("nit", "moderate", "critical"), not emoji-based ones. This mismatch
could cause confusion for automated review tools trying to parse these
instructions.
```suggestion
When leaving comments, use the following severity levels recognized by the
review tooling (`store_comment`): `nit`, `moderate`, and `critical`:
- **critical** (🔴 Critical): Must fix before merge (correctness, safety,
breaking changes)
- **moderate** (🟠 Important): Should fix before merge (error handling,
testing, docs)
- **nit** (🟡 Suggestion): Nice to have, not blocking (style, optimization)
- **Question** (💬, optional tag): Clarification needed, not necessarily an
issue; combine with an appropriate severity above
```
##########
.github/instructions/code-review.instructions.md:
##########
@@ -0,0 +1,159 @@
+---
+applyTo: "**/*"
+excludeAgents: ["coding-agent"]
+---
+
+# Code Review Instructions for Apache Hudi-rs
+
+## Multi-Round Review Behavior
+
+### Handling Subsequent Commits
+
+When reviewing a PR that has been updated with new commits after a previous
review:
+
+1. **Check if previous comments are addressed**:
+ - Compare the current code state against previous review comments
+ - If a comment has been addressed by new changes, acknowledge resolution
+ - Do NOT re-raise issues that have been fixed
Review Comment:
The comment states "Do NOT re-raise issues that have been fixed" but this
guidance conflicts with the general instruction that if an issue is fixed in
updated code, it should be marked with "fixed" set to true. Consider clarifying
that resolved issues should still be noted but marked as resolved rather than
completely ignored.
```suggestion
- Do NOT re-raise fixed issues as new findings; instead, note them as
resolved and, where applicable, mark them as fixed
```
##########
.github/instructions/code-review.instructions.md:
##########
@@ -0,0 +1,159 @@
+---
+applyTo: "**/*"
+excludeAgents: ["coding-agent"]
Review Comment:
The YAML frontmatter uses "excludeAgents" but it's unclear if this is a
valid field for GitHub Copilot instructions. The documentation for Copilot
instructions typically only mentions "applyTo" in the frontmatter. Consider
verifying this field is supported or documenting its purpose.
##########
.github/copilot-instructions.md:
##########
@@ -0,0 +1,125 @@
+# GitHub Copilot Instructions for Apache Hudi-rs
+
+## Project Overview
+
+Apache Hudi-rs is the native Rust implementation of Apache Hudi, providing
Python and C++ API bindings. The project focuses on standardizing core Apache
Hudi APIs and broadening Hudi integration in the data ecosystem.
+
+### Key Dependencies & Ecosystem
+
+- **Apache Arrow**: In-memory columnar format (via `arrow-rs` crate)
+- **Apache DataFusion**: Query execution engine integration
+- **Apache Parquet**: Columnar storage format
+- **PyO3**: Python bindings
+- **CXX**: C++ FFI bindings
+- **Tokio**: Async runtime
+
+## Commit Conventions
+
+This project uses [Conventional Commits](https://www.conventionalcommits.org).
PR titles must follow this format:
+
+```
+<type>(<scope>): <description>
+```
+
+Types: `feat`, `fix`, `docs`, `style`, `refactor`, `perf`, `test`, `build`,
`ci`, `chore`
+
+Examples:
+- `feat(core): add support for MOR table reads`
+- `fix(python): handle null partition values correctly`
+- `docs: update API documentation for HudiTable`
+
+## Development Setup
+
+See [CONTRIBUTING.md](../CONTRIBUTING.md) for full details.
+
+### Prerequisites
+
+- Rust (see `rust-toolchain.toml`)
+- [uv](https://docs.astral.sh/uv/) - Python package manager
+- Python (see `python/pyproject.toml` for version)
+
+### Quick Start
+
+```bash
+# Setup Python virtual environment
+make setup-venv
+source .venv/bin/activate
+
+# Install for development (builds Rust + Python bindings)
+make develop
+
+# Format and lint
+make format check
+
+# Run all tests
+make test
+```
+
+## Code Review Guidelines
+
+### Multi-Round Review Behavior
+
+When reviewing subsequent commits on a PR:
+
+1. **Auto-resolve addressed comments**: If a new commit addresses a previous
review comment, acknowledge it is resolved rather than re-raising the same
issue.
+2. **Focus on new changes**: Prioritize reviewing newly added or modified code
in the latest commits.
+3. **Track incremental progress**: Recognize when feedback has been
incorporated and provide confirmation.
+4. **Avoid duplicate comments**: Do not repeat comments that have been
addressed in subsequent commits.
Review Comment:
The instruction states "Avoid duplicate comments: Do not repeat comments
that have been addressed in subsequent commits." However, this conflicts with
standard code review practices where addressed issues should be acknowledged.
Consider revising to clarify that the same issue should not be re-raised as a
new problem, but can be acknowledged as resolved.
```suggestion
4. **Avoid duplicate comments**: Do not re-raise the same issue as a new
problem once it has been addressed; you may still reference earlier comments to
acknowledge resolution.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
