umehrot2 commented on a change in pull request #2417:
URL: https://github.com/apache/hudi/pull/2417#discussion_r554244342
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java
##########
@@ -64,6 +111,6 @@ public
FileSystemBackedTableMetadata(SerializableConfiguration conf, String data
@Override
public boolean isInSync() {
- throw new UnsupportedOperationException();
+ return false;
Review comment:
I guess. But setting it to true breaks
https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/metadata/TestHoodieBackedMetadata.java#L456
and others. I guess will look at the tests again to see if those need to be
fixed instead. I don't really see `isInSync()` being used anywhere (in source
code, apart from tests) except for being stored in stats somewhere. Wonder if
its really needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
